FMWK-258 Refactor Operations/Template #651
Conversation
…message to use the new ones "deleteAll" and "deleteById".
…eactive flows 2. Improve README 3. Add missing reactive operation methods 4. Polish API (methods naming, fields naming, javadocs, interface and implementation ordering...)
…rations # Conflicts: # src/main/java/org/springframework/data/aerospike/repository/query/AerospikeQueryCreator.java
| @Override | ||
| public <T> Stream<T> findAll(Class<T> entityClass) { | ||
| Assert.notNull(entityClass, "Entity class must not be null!"); | ||
| private void checkForErrors(IAerospikeClient client, Key[] keys) { |
There was a problem hiding this comment.
It's better to rename to something like deleteAndHandleErrors
|
|
||
| /** | ||
| * Find documents in the given entityClass's set using a query and map them to the given target class type. | ||
| * Add integer/double bin values to existing document bin values with a given set name, read the new modified | ||
| * document and map it back the given document class type. |
There was a problem hiding this comment.
map it back the given document class type -> map it back to the given document class type
For all related methods.
README.adoc
Outdated
| issue] for a feature request or bug fixing, comment and vote on the ones that | ||
| you are interested in | ||
| * GitHub is for social coding: we encourage contributions through pull requests from | ||
| https://help.github.com/forking/[forks of this repository]. when contributing code, |
There was a problem hiding this comment.
when contributing code -> When contributing code (capital letter)
README.adoc
Outdated
| * GitHub is for social coding: we encourage contributions through pull requests from | ||
| https://help.github.com/forking/[forks of this repository]. when contributing code, | ||
| please reference a specific GitHub issue you are addressing | ||
| covering the specific case you are addressing |
There was a problem hiding this comment.
Let's have something like "When contributing code, please reference a specific GitHub issue you are addressing". Do you agree?
| to Aerospike Stand-Up |
There was a problem hiding this comment.
I think there has to be a full stop (".") in the end of this sentence. What do you think?
There was a problem hiding this comment.
For some reason my previous comment was deleted.
I think that since its a part of a list of bullet points it should be aligned with the rest of the bullet points and there shouldn't be "." at the end of the sentence.
No description provided.